[MPlayer-dev-eng] [PATCH 2/3] Fix some warnings with Objective-C code and declarations

[Alexander Strasser]

On 2013-07-15 21:13 +0200, Alexander Strasser wrote:
> On 2013-07-15 08:09 +0800, Xidorn Quan wrote:
> > On Sun, Jul 14, 2013 at 8:38 PM, Jiang Jiang <gzjjgod at gmail.com> wrote:
> > 
> > > ---
> > >  libvo/osx_objc_common.h | 2 +-
> > >  libvo/osx_objc_common.m | 4 ++--
> > >  libvo/vo_corevideo.h    | 2 +-
> > >  libvo/vo_corevideo.m    | 7 ++++---
> > >  4 files changed, 8 insertions(+), 7 deletions(-)
> > >
> [...]
> > 
> > LGTM.
> 
>   IIRC you are on OSX and you can commit to the MPlayer repository.
> 
>   So it should be fine for you to apply this if you think it is correct.
> Do not forget the attribution to the author, it can happen easily.
> 
>   Maybe splitting the patch into rename method and include part
> would be better as well as is including the compiler warning in
> the body of the commit message.
> 
>   I just forgot because I cut out the patch from the email, but would
> configureSize be a better name than configWidth?
  ^^^^^^^^^
  Oooops, I meant configSize no need to spell out configure of course.

  Alexander