[MPlayer-dev-eng] [PATCH] Fix FOURCC format check in mplayer.c

[Hans-Dieter Kosch]

compn wrote:
> On Wed, 14 Aug 2013 00:46:47 +0200, Hans-Dieter Kosch wrote:
>> Hi,
>>
>> some time ago I sent a patch to fix FOURCC format check in mplayer.c;
>> there was no response yet, so I send it again.
>>
>> The comment in the code says:
>> /* Assume FOURCC if all bytes >= 0x20 (' ') */
>> But this can only work if it is checked byte by byte instead of a single long 
>> word (e.g. 0x2020211f >= 0x20202020 holds falsely true).
> 
> is this only used in the -identify option?

I suppose, yes. It applies to mp_msg(MSGT_IDENTIFY, ...).

Hans-Dieter