[MPlayer-dev-eng] [PATCH] Fix a bunch of fresh -Wundef warnings...

[Alexander Strasser]

Hi Erik,

Erik Auerswald wrote:
> On 10/25/2012 10:51 PM, Erik Auerswald wrote:
> >compiling a current svn checkout of MPlayer with a current git clone of
> >FFmpeg shows the following new warnings:
> >
> >libavutil/libm.h:36:6: warning: "HAVE_ATANF" is not defined [-Wundef]
> >libavutil/libm.h:41:6: warning: "HAVE_ATAN2F" is not defined [-Wundef]
> >libavutil/libm.h:46:6: warning: "HAVE_POWF" is not defined [-Wundef]
> >libavutil/libm.h:58:6: warning: "HAVE_COSF" is not defined [-Wundef]
> >libavutil/libm.h:63:6: warning: "HAVE_EXPF" is not defined [-Wundef]
> >libavutil/libm.h:98:6: warning: "HAVE_LDEXPF" is not defined [-Wundef]
> >libavutil/libm.h:123:6: warning: "HAVE_LOG10F" is not defined [-Wundef]
> >libavutil/libm.h:128:6: warning: "HAVE_SINF" is not defined [-Wundef]
> >
> >Seems some new FFmpeg #defines that need to be added somewhere™. Does
> >anybody know where new FFmpeg feature test macros are supposed to be
> >added? More specific than "to configure", please. ;-)
> 
> The attached patch adds checks to create the above HAVE_* defines to
> configure. The many silenced warnings show additional missing HAVE_*
> defines...

  your patch looks good to me. Also if I am not too tired it actually
does fix a few wrong decisions (on some systems libm.h will redefine
math functions that are actually there) as opposed to only silencing
warnings.

  I will commit Sunday evening if I hear no objections.

  Alexander

> Index: configure
> ===================================================================
> --- configure	(revision 35275)
> +++ configure	(working copy)
> @@ -3195,7 +3195,7 @@
>  echores "$_kstat"
>  
>  
> -for func in cbrtf exp2 exp2f isnan isinf llrint llrintf log2 log2f lrint lrintf rint round roundf trunc truncf; do
> +for func in atanf cbrtf cosf expf exp2 exp2f isnan isinf llrint llrintf log2 log2f log10f lrint lrintf rint round roundf sinf trunc truncf; do
>  echocheck $func
>  eval _$func=no
>  statement_check math.h "${func}(2.0)" -D_ISOC99_SOURCE && eval _$func=yes
> @@ -3209,6 +3209,20 @@
>  done
>  
>  
> +for func in atan2f ldexpf powf; do
> +echocheck $func
> +eval _$func=no
> +statement_check math.h "${func}(1.0,1.0)" -D_ISOC99_SOURCE && eval _$func=yes
> +if eval test "x\$_$func" = "xyes"; then
> +  eval def_$func="\"#define HAVE_$(echo $func | tr '[a-z]' '[A-Z]') 1\""
> +  echores yes
> +else
> +  eval def_$func="\"#define HAVE_$(echo $func | tr '[a-z]' '[A-Z]') 0\""
> +  echores no
> +fi
> +done
> +
> +
>  echocheck "mkstemp"
>  _mkstemp=no
>  define_statement_check "_XOPEN_SOURCE 600" "stdlib.h" 'mkstemp("")' && _mkstemp=yes
> @@ -8831,7 +8845,11 @@
>  $def_bswap
>  $def_bzlib
>  $def_dcbzl
> +$def_atanf
> +$def_atan2f
>  $def_cbrtf
> +$def_cosf
> +$def_expf
>  $def_exp2
>  $def_exp2f
>  $def_fast_64bit
> @@ -8841,6 +8859,7 @@
>  $def_ibm_asm
>  $def_isinf
>  $def_isnan
> +$def_ldexpf
>  $def_libavcodec_mpegaudio_hp
>  $def_llrint
>  $def_llrintf
> @@ -8848,6 +8867,7 @@
>  $def_local_aligned_16
>  $def_log2
>  $def_log2f
> +$def_log10f
>  $def_lrint
>  $def_lrintf
>  $def_mlib
> @@ -8858,10 +8878,12 @@
>  $def_pic
>  $def_poll_h
>  $def_posix_memalign
> +$def_powf
>  $def_pthreads
>  $def_rint
>  $def_round
>  $def_roundf
> +$def_sinf
>  $def_threads
>  $def_trunc
>  $def_truncf