[MPlayer-dev-eng] [PATCH 6/7] stream ftp: Allocate command buffer on-heap

Alexander Strasser eclipse7 at gmx.net
Mon Nov 12 21:09:59 CET 2012


Reimar Döffinger wrote:
> On Sun, Nov 11, 2012 at 10:01:41PM +0100, Alexander Strasser wrote:
> > +    snprintf(p->cmd_buf,CMD_BUFSIZE - 1,"REST %"PRId64, (int64_t)newpos);
> 
> There should be no -1 for the size argument (same for all other
> snprintfs).

  Yes :(  I noticed that too...

  But this "error" (should not have bad effects because of the NUL termination)
is repeated all over the file. So I would prefer to send a separate patch to
fix all occurrences.

  Alexander


More information about the MPlayer-dev-eng mailing list