[MPlayer-dev-eng] [PATCH 3/7] stream ftp: readline: Always try to read complete lines

Alexander Strasser eclipse7 at gmx.net
Mon Nov 12 17:49:19 CET 2012


Hi Erik,

Erik Auerswald wrote:
> On Sun, Nov 11, 2012 at 10:01:09PM +0100, Alexander Strasser wrote:
> > [...]
> > diff --git a/stream/stream_ftp.c b/stream/stream_ftp.c
> > index 333c133..a24117c 100644
> > --- a/stream/stream_ftp.c
> > +++ b/stream/stream_ftp.c
> > @@ -104,6 +104,11 @@ static int fd_can_read(int fd,int timeout) {
> >  /*
> >   * read a line of text
> >   *
> > + * If the line is too long to fit in the buffer, provided via parameters
> > + * buf and max, the remaining characters are skipped. So the next call to
> > + * this function is synchronized to the start of the following following
>                                                         ^^^^^^^^^^^^^^^^^^^
> s/ following//1
> 
> > [...]
> 
> Sorry, I can't really comment on the code changes...

  Thanks for reading the patches anyway!

  Fixed the duplication locally.

  Judging from your E-Mail address you might be able to do some
local testing of these changes at your site. Would be welcome :)


  Alexander


More information about the MPlayer-dev-eng mailing list