[MPlayer-dev-eng] [PATCH]Support 64bit tiff via opengl

[Carl Eugen Hoyos]

Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:

> On Sat, Jan 14, 2012 at 01:47:30PM +0100, Carl Eugen Hoyos wrote:
> > Index: libmpcodecs/mp_image.c
> > ===================================================================
> > --- libmpcodecs/mp_image.c	(revision 34561)
> > +++ libmpcodecs/mp_image.c	(working copy)
> > @@ -107,7 +107,9 @@
> >      }
> >      mpi->num_planes=1;
> >      if (IMGFMT_IS_RGB(out_fmt)) {
> > +        if (out_fmt == IMGFMT_RGBA64LE || out_fmt == IMGFMT_RGBA64BE) {
> > +            mpi->bpp = 64;
> > -        if (IMGFMT_RGB_DEPTH(out_fmt) < 8 && !(out_fmt&128))
> > +        } else if (IMGFMT_RGB_DEPTH(out_fmt) < 8 && !(out_fmt&128))
> 
> If you want that, move the BE signalling to | 128 for all formats and
> change IMGFMT_RGB_DEPTH to use & 0x7F

I think I do not understand: "|64" is used to signal "non-native-endian" iiuc,
BE is already signalled with "|128" for all formats, or am I wrong?

Since I don't know where "non-native-endian" is used, I cannot change it...

> > +    {"RGBA64LE",     IMGFMT_RGBA64LE},
> > +    {"RGBA64BE",     IMGFMT_RGBA64BE},
> >      {"RGB48LE",     IMGFMT_RGB48LE},
> 
> Indentation is off.

Fixed locally.

> > +  {"rgba64be", IMGFMT_RGBA64BE},
> > +  {"rgba64le", IMGFMT_RGBA64LE},
> 
> If you call it RGBA that would imply a variant without
> "A". There is not really any encoding left for that then though?

Changed to:
+  {"rgb64be", IMGFMT_RGBA64BE},
+  {"rgb64le", IMGFMT_RGBA64LE},
Is that what you meant?

Carl Eugen