[MPlayer-dev-eng] [PATCH] cleanup faterun.sh, do not use / if FATE_SAMPLES is not set

[Reimar Döffinger]

On 6 Jan 2012, at 15:46, Diego Biurrun <diego at biurrun.de> wrote:
> On Thu, Jan 05, 2012 at 02:01:07PM +0100, Reimar Döffinger wrote:
>> Hello,
>> currently fatetest behaves badly if FATE_SAMPLES is not set.
>> And the script contains code duplication and bad variables names like
>> "i".
>> Attached patch IMO is much better.
> 
>> --- Makefile    (revision 34508)
>> +++ Makefile    (working copy)
>> @@ -996,6 +996,7 @@
>> 
>> +ifdef FATE_SAMPLES
>> ALLSAMPLES_FULLPATH = $(wildcard $(FATE_SAMPLES)/*/*.*)
>> ALLSAMPLES          = $(patsubst $(FATE_SAMPLES)/%,%,$(ALLSAMPLES_FULLPATH))
>> SAMPLES := $(filter-out $(BROKEN_SAMPLES),$(ALLSAMPLES))
>> @@ -1006,6 +1007,7 @@
>> 
>> tests/res/%.md5: mplayer$(EXESUF) $(FATE_SAMPLES)/%
>>    @tests/faterun.sh $*
>> +endif
> 
> This is pointless - the declarations are harmless unless you really run
> fatetest, which should now give an error message.

I am afraid it is not harmless.
wildcard ends up scanning / in that case which for some users contains so many files that make seems to hang.
And no, not just when running fatetest.