[MPlayer-dev-eng] ALSA non-blocking mode

[Ingo Brückl]

Reimar Döffinger wrote on Mon, 13 Feb 2012 20:07:58 +0100:

> On Mon, Feb 13, 2012 at 02:28:53PM +0100, Ingo Brückl wrote:
>> Just curious: What is non-blocking mode and why is the device opened with
>> regard to the "block" suboption of the alsa driver (ao_alsa.c, line 466)
>> and set to blocking mode right afterwards (line 480)?

> I guess it could be that there are ALSA devices/versions that cannot
> work in blocking mode (which with the current code would just result
> in a warning but possibly would not fail),

Well, in that case we could improve at least the messages that tell about the
mode (patch #1).

> but most likely nobody though to or all were too lazy to clean up the code.
> If you want feel free to throw away all the code related to non-blocking
> and see what happens.

In that case patch #2 should be applied. I didn't notice any problems while
testing it with my ALSA devices/version.

Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ao_alsa.1.patch
Type: text/x-diff
Size: 967 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20120216/3f549163/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ao_alsa.2.patch
Type: text/x-diff
Size: 1992 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20120216/3f549163/attachment-0001.bin>