[MPlayer-dev-eng] [PATCH] GUI: Enhancement to r35555

Ingo Brückl ib at wupperonline.de
Mon Dec 10 15:29:19 CET 2012


Hans-Dieter Kosch wrote on Sun, 09 Dec 2012 21:48:24 +0100:

> Ingo Brückl wrote:
>> Hans-Dieter Kosch wrote on Sat, 08 Dec 2012 23:31:27 +0100:
>>
>>> If the current file is still present in the list, playback continues with
>>> adjusted position.
>>
>> I've considered this in r35555, but we don't know anything about the files
>> before the present one. These might have changed, too, so it's best to
>> restart playback, because I don't think it's worth to check the list of file
>> before it. (The reason for r35555 was to allow adding to the playlist while
>> playing, not to change it at this stage.)
>>
> This was also my concern at first. However, since the playlist is
> completely recreated upon selecting 'OK', we are always in sync, and it
> works flawlessly. You can edit anything in the list, no issue will arise.
> Or did I miss something?

No, there is no problem with the list or on-the-fly editing.

It's just that we don't know what the user meant with the editing if the
position has changed (inserting an item, or delete one and/or exchanging some
before the current one). To avoid extensive analysis that probably won't help
us anyway, we simply restart. It's not worth the effort.

Ingo


More information about the MPlayer-dev-eng mailing list