[MPlayer-dev-eng] MPlayer-dev-eng Digest, Vol 116, Issue 3

[Clément Bœsch]

On Tue, Aug 07, 2012 at 10:01:16PM +0200, Clément Bœsch wrote:
[...]
> > > What if "color=yellow", will that work?
> > >
> > > I think you are the 3rd guy to propose a patch for this... Wasn't the last
> > > one approved?
> > >
> > > It might be interesting to replace this code with the FFmpeg API which
> > > might handle that in a better way.
> > >
> > 
> > 
> > Hi!
> > 
> > I didn't patch the code to accept constructs such as *color=yellow* (i.e.,
> > without any quotation symbols) because I never found such cases.
> > 
> 
> Well it's certainly possible there are some.
> 
> > As to *color=#ff0000*, I got the latest MPlayer version and it was still
> > being rejected, as the pictures I sent show.
> > 
> 
> Yeah I mean someone already posted a more advanced patch from Szokovacs
> Robert:
> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2012-April/070237.html
> 
> (which IIRC was already superseding another)
> 
> Unfortunately I never had time to review it properly or fix what was
> eventually missing.
> 
> I'll give it a try soon© but I can't promise anything. If any other dev
> feel like one patch should be applied as-is, go for it.
> 

I committed something to support the unquoted attributes. I didn't try
with your sample but it should work. Feel free to flame me in case it
doesn't.

Thanks.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20120810/61933dec/attachment.asc>