[MPlayer-dev-eng] [PATCH] Allow EDL's to work better with DVD's

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Apr 20 20:21:52 CEST 2012


On Wed, Apr 18, 2012 at 10:39:08AM -0600, Roger Pack wrote:
> Currently EDL relies on mpctx->sh_video->pts which (as noted earlier)
> can "reset" half way through a DVD, thus applying skips or mutes to
> any segment past that mark doesn't work.  Patch to remedy this.
> 
> -roger-
> 
> https://github.com/rdp/mplayer-svn/commit/5ac533baf061a50809adbe6a3b0133b0e334ff8f
> 
> diff --git a/mplayer.c b/mplayer.c
> index 3a5e38a..38f023c 100644
> --- a/mplayer.c
> +++ b/mplayer.c
> @@ -2608,7 +2608,8 @@ static void edl_update(MPContext *mpctx)
>          edl_records     = NULL;
>          return;
>      }
> -
> +	
> +    double pts = demuxer_get_current_time(mpctx->demuxer);	

Trailing whitespace and mixed declaration and code.
Also, I am not sure the check for sh_video before makes any sense
anymore then, since it is now most important that mpctx->demuxer
is not NULL, otherwise the whole code will break.
Otherwise it looks like a very sensible change.


More information about the MPlayer-dev-eng mailing list