[MPlayer-dev-eng] [RFC PATCH] Default to subtitle visibility off (was Re: Question for dev's: Does mplayer disable DPMS timeouts? "xset q" looks good, but timeouts never trigger)

Erik Auerswald auerswal at unix-ag.uni-kl.de
Mon Sep 26 00:13:56 CEST 2011


Ping again,

On 09/18/2011 02:51 PM, Erik Auerswald wrote:
> no comments regarding the small patch that hides subtitles unless the
> subtitle selection code actually selects a subtitle stream?
>
> On 09/09/2011 09:54 PM, Erik Auerswald wrote:
>> [...]
>> The attached patch (actually tested) is a definite improvement for me.
>> When specifying -slang XX or having a suitably named .srt file lying
>> near a movie, subtitles are displayed. But the mere presence of
>> subtitles on a DVD does not result in displaying them automatically.
>>
>> Please consider applying.
>
> The patch still applies cleanly.

It still does.

The change in behavior is practically just hiding subtitles on DVD 
unless a subtitle language is specified. In all other cases (MPlayer 
finds some subtitles, e.g. because of command line or file name) they 
are still displayed.

ACK/NAK/Timeout?

Thanks,
Erik


More information about the MPlayer-dev-eng mailing list