[MPlayer-dev-eng] [PATCH] Fix for fix for mpeg2 A/V sync bug.

Dan Oscarsson Dan.Oscarsson at tieto.com
Sat Oct 22 18:25:23 CEST 2011


Hi

In August we removed an older fix for bad pts values on video as it
resulted in bad a/v sync when playing NTSC DVDs. Nobody them remembered
why it was there.

Recently I sent an updated mplayer with my patches added to a friend who
plays a lot of mpeg-ts files gotten from DVB-t TV streams. And they no
longer played correctly. I checked and now I remember that about a year
ago I had a patch for this, but we never included my patch instead the
above patch we removed, fixed it.

The problem is that when playing a mpeg-ts file with h264 in, pts values
are not reordered as demux_ts do not set correct-pts. This results in
pts values not being in order.

As the above removed patch had problems with NTSC DVDs I suggest we
instead we patch a modified version of my old patch.

The attached patch enables so re-order of pts values are always done.
I cannot think of when this should be a problem. Looks good in all my
tests.

While it is not in my patch I cannot see any problem to also removing
the test for pts != MP_NOPTS_VALUE as that will just handle
MP_NOPTS_VALUE pts values in re-ordering as a very negative value.

   Dan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: reorder-fix.patch
Type: text/x-patch
Size: 914 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111022/5df4ab1e/attachment.bin>


More information about the MPlayer-dev-eng mailing list