[MPlayer-dev-eng] [PATCH 3/5] Prettify main MPlayer source file.

Clément Bœsch ubitux at gmail.com
Sun May 1 19:31:22 CEST 2011


On Sun, May 01, 2011 at 07:13:36PM +0200, Reimar Döffinger wrote:
> > > [...]
> > > Maybe something like this would do:
> > > Index: Makefile
> > > ===================================================================
> > > --- Makefile	(revision 33269)
> > > +++ Makefile	(working copy)
> > > @@ -820,6 +820,12 @@
> > >  codecs.conf.h: codec-cfg$(EXESUF) etc/codecs.conf
> > >  	./$^ > $@
> > >  
> > > +checksums: $(MPLAYER_DEPS) $(MENCODER_DEPS) mplayer$(EXESUF) mencoder$(EXESUF)
> > > +	md5sum $^ > checksums
> > > +
> > > +check_checksums: $(MPLAYER_DEPS) $(MENCODER_DEPS) mplayer$(EXESUF) mencoder$(EXESUF)
> > > +	md5sum -c checksums
> > > +
> > >  # ./configure must be rerun if it changed
> > >  config.mak: configure
> > >  	@echo "############################################################"
> > > @@ -1112,7 +1118,7 @@
> > >  -include $(DEP_FILES) $(DRIVER_DEP_FILES) $(TESTS_DEP_FILES) $(TOOLS_DEP_FILES) $(DHAHELPER_DEPS_FILES)
> > >  
> > >  .PHONY: all doxygen *install* *tools drivers dhahelper*
> > > -.PHONY: checkheaders *clean tests
> > > +.PHONY: checkheaders *clean tests check_checksums
> > >  
> > >  # Disable suffix rules.  Most of the builtin rules are suffix rules,
> > >  # so this saves some time on slow systems.
> > 
> > Do you mind committing this or sth similar? Even if it's not perfect it's
> > pretty useful, and i'd like to get done with that bunch of cosmetic
> > patches…
> 
> Sure, Diego can still flame me on -cvslog if it's bad :-)

Thank you :)

-- 
Clément B.


More information about the MPlayer-dev-eng mailing list