[MPlayer-dev-eng] [PATCH] Abort on Fatal Messages

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Mar 13 13:17:06 CET 2011


On Sun, Mar 13, 2011 at 12:03:13PM +0100, Alexander Strasser wrote:
>   Reimar, what is your opinion on this approach?

Honestly I think most to all FATAL error messages are _potentially_
fatal but not necessarily.
If we just exit that means
1) we can't continue if for some reason in this specific case it is not fatal
2) we can never use FATAL level if we still have some cleanup to do

I can't even see why this would ever be an improvement, the argument
about the messages being the last one and thus clearer to see seems
bogus as well, if there are more messages it obviously wasn't fatal,
or at least not immediately.
Whatever the desired purpose, coupling message printing and termination
seems completely wrong from a design point to me.


More information about the MPlayer-dev-eng mailing list