[MPlayer-dev-eng] [PATCH] Abort on Fatal Messages

[Ingo Brückl]

Tobias Diedrich wrote on Wed, 9 Mar 2011 19:47:18 +0100:

> Abort on fatal messages.

> mp_msg.h says we abort on fatal messages, but we currently don't.

In my understanding it means that fatal messages should be issued
if aborting (or exiting) has to occur, but not...

> Index: mplayer-patchset1/mp_msg.c
> ===================================================================
> +++ mplayer-patchset1/mp_msg.c  2011-02-18 20:02:26.823321000 +0100
> @@ -242,4 +242,7 @@
>      if (mp_msg_color)
>          fprintf(stream, "\033[0m");
>      fflush(stream);
> +
> +    if (lev == MSGL_FATAL)
> +        abort();
>  }

...that this should happen immediately. The calling code should be
responsible for that. Maybe some cleanup has to be done first and normal
exiting is possible.

Ingo