[MPlayer-dev-eng] [PATCH RESEND] Mac OS X: fix libao2 compilation on Mac OS X 10.4

Diego Biurrun diego at biurrun.de
Wed Jan 5 11:49:20 CET 2011


On Sun, Dec 19, 2010 at 04:38:52PM +0200, Aaro Koskinen wrote:
>
> On Wed, 15 Dec 2010, Diego Biurrun wrote:
>> On Fri, Dec 10, 2010 at 11:48:55PM +0200, Aaro Koskinen wrote:
>>> +#define AudioDeviceIOProcID AudioDeviceIOProc
>>> +#define AudioDeviceDestroyIOProcID AudioDeviceRemoveIOProc
>>> +static OSStatus AudioDeviceCreateIOProcID(AudioDeviceID dev,
>>> +					  AudioDeviceIOProc proc,
>>> +					  void *data,
>>> +					  AudioDeviceIOProcID *procid)
>>> +{
>>> +	*procid = proc;
>>> +	return AudioDeviceAddIOProc(dev, proc, data);
>>> +}
>>> +#endif
>>> +
>>>  typedef struct ao_coreaudio_s
>>>  {
>>
>> Please place your function below the struct declaration.
>
> I can move it if that's needed, I just wanted to avoid creating multiple
> #if ... #endif sections.

I don't see why moving the function a few lines down would entail adding
more #ifdefs.

I tried your patch, but it does not apply here.  Please refresh it and
address the above comment.

Diego


More information about the MPlayer-dev-eng mailing list