[MPlayer-dev-eng] the great reformatting

[Diego Biurrun]

On Tue, Feb 15, 2011 at 03:24:55AM +0100, Ingo Brückl wrote:
> Diego Biurrun wrote on Tue, 15 Feb 2011 01:53:55 +0100:
> 
> > I used a git clone from today.
> 
> But the config options are v0.54?

It evolved from a config for v0.54, maybe I attached the wrong file,
will doublecheck again.

> > Constructive comments are welcome,
> 
> As I mentioned earlier, I - personally - wouldn't align '=' statements.

Local convention overrules you :-)

> A few questions from a K&R style inexperienced guy:
> 
> No new line after a block of variable definitions?
> -------------------------------------------------
> void fntFreeFont(void)
> {
>     int i;
>     for (i = 0; i < MAX_FONTS; i++)
> -------------------------------------------------

Hmm, I'll look into the holy book again.

> This is a strange amount of spaces between ) and { in font.c (could be a bug):
> -------------------------------------------------
>         } else if (!strcmp(command, "image"))     {
> -------------------------------------------------

That's a bug in uncrustify.  Which file triggered it?

> No new line after the case label?
> -------------------------------------------------
>         case fntAlignLeft:   dx = 0;
>             break;
> -------------------------------------------------
> 
> Similar in fs.c:
> -------------------------------------------------
>     default: return;
> -------------------------------------------------

That looks like a bug in the configuration.  Which file
triggered it?

Diego