[MPlayer-dev-eng] [PATCH] More warnings

[Diego Biurrun]

On Thu, Feb 03, 2011 at 02:20:37AM +0100, Ingo Brückl wrote:
> Diego Biurrun wrote on Wed, 02 Feb 2011 16:50:38 +0100:
> 
> > Restructuring configure to enable -Wextra and -Wwhatnot with an option
> > like --enable-extra-warnings or so could be an alternative.
> 
> Ok, here is a suggestion with a new call for objections.
> 
> --- configure	(revision 32841)
> +++ configure	(working copy)
> @@ -2579,7 +2583,12 @@
>      CFLAGS="-O4 $_march $_mcpu $_pipe -ffast-math -fomit-frame-pointer"
> -    WARNFLAGS="-Wall -Wno-switch -Wno-parentheses -Wpointer-arith -Wredundant-decls"
> +    if test "$_extra_warnings" = "yes"; then
> +      EXTRAWARN="-Wextra -Wcast-align"
> +    else
> +      EXTRAWARN="-Wno-switch -Wno-parentheses"
> +    fi
> +    WARNFLAGS="-Wall $EXTRAWARN -Wpointer-arith -Wredundant-decls"

I'm not sure why you don't just append to WARNFLAGS.

Anyway, here is a patch that adds some more warning flags that
FFmpeg also enables.  Comments welcome.

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: warnings.diff
Type: text/x-diff
Size: 712 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110208/d265dc92/attachment.diff>