[MPlayer-dev-eng] [PATCH] Capture feature

[Diego Biurrun]

On Mon, Sep 13, 2010 at 07:28:44PM +0200, Pásztor Szilárd wrote:
> 
> diff -NurpabB -NurpabB mplayer-export-2010-09-13/cfg-mplayer.h mplayer-export-2010-09-13-capture/cfg-mplayer.h
> --- mplayer-export-2010-09-13/cfg-mplayer.h	2010-09-08 07:29:05.000000000 +0200
> +++ mplayer-export-2010-09-13-capture/cfg-mplayer.h	2010-09-13 19:02:32.000000000 +0200

You don't use svn?

> --- mplayer-export-2010-09-13/command.c	2010-09-09 17:46:25.000000000 +0200
> +++ mplayer-export-2010-09-13-capture/command.c	2010-09-13 19:07:32.000000000 +0200
> @@ -70,6 +70,8 @@
>  
> +char *capture_dump_name = NULL;

Declare this closer to where it is actually used..

> @@ -1108,6 +1110,48 @@ static int mp_property_deinterlace(m_opt
>  
> +    switch (ret) {
> +    case M_PROPERTY_ERROR:
> +        set_osd_msg(OSD_MSG_SPEED, 1, osd_duration, MSGTR_OSDCapturingFailure);
> +        break;
> +    case M_PROPERTY_OK:
> +        set_osd_msg(OSD_MSG_SPEED, 1, osd_duration, MSGTR_OSDCapturing,
> +            mpctx->stream->capture_file ? MSGTR_Enabled : MSGTR_Disabled);

Indentation is off.

> --- mplayer-export-2010-09-13/DOCS/man/en/mplayer.1	2010-09-08 07:29:05.000000000 +0200
> +++ mplayer-export-2010-09-13-capture/DOCS/man/en/mplayer.1	2010-09-13 19:08:09.000000000 +0200
> @@ -1340,6 +1342,17 @@ from the current position, MPlayer will 
>  this position rather than performing a stream seek (default: 50).
>  .
>  .TP
> +.B \-capturefile <filename> (MPlayer only)
> +Allows capturing the primary stream (e.g. not additional audio or others)

e.g.\&

> +Note that, due to cache latencies, captured data may start and stop
> +somewhat delayed compared to what you see displayed.

You mean that there is a delay between the keypress and MPlayer's reaction
to the keypress?

> --- mplayer-export-2010-09-13/mplayer.h	2010-09-11 14:13:30.000000000 +0200
> +++ mplayer-export-2010-09-13-capture/mplayer.h	2010-09-13 19:04:12.000000000 +0200
> @@ -41,6 +41,8 @@ extern int auto_quality;
>  extern int disable_gui_conf;
>  extern int stream_dump_type;
>  
> +extern char *capture_dump_name;

This belongs in command.h.


Reimar, are you now OK with the patch?  Then I think it can be applied.

Diego