[MPlayer-dev-eng] [PATCH] EDL changes: loadfile and adjust pts functionality

[Vlad Seryakov]

On Sep 1, 2010, at 8:24 PM, Reynaldo H. Verdejo Pinochet wrote:

> Hi again  Vlad
> 
> On Wed, Sep 01, 2010 at 07:45:22PM -0400, Vlad Seryakov wrote:
>> [...] 
>> 
>> i only add to help_mp-en.h, right?
> 
> Yes, thanks.
> 
>> [...]
>>   int brk_cmd = 0;
>>   while( !brk_cmd && (cmd = mp_input_get_cmd(0,0,0)) != NULL) {
>>       brk_cmd = run_command(mpctx, cmd);
>> +      if (cmd->id == MP_CMD_EDL_LOADFILE) {
>> +          if (edl_filename) free(edl_filename);
>> +          edl_filename = strdup(cmd->args[0].v.s);
>> +          if (!edl_filename) {
>> +              mp_msg(MSGT_CPLAYER, MSGL_ERR, MSGTR_EdlOutOfMemFile, cmd->args[0].v.s);
>> +          }
>> +          edl_loadfile();
> 
> Please drop the pointless braces and consider making it an
> if/else clause. I know edl_loadfile() won't do a thing
> with a NULL edl_filename but there is no need to call
> it in that case and you already have the if so...
> 

Done

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: edlfile.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100901/9d88f61d/attachment.txt>
-------------- next part --------------