[MPlayer-dev-eng] [PATCH] Move subreader.[ch] to a dedicated sub directory

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Oct 25 21:58:02 CEST 2010


On Mon, Oct 25, 2010 at 10:59:22AM +0200, Nicolas George wrote:
> As was planned, the attached patch:
> 
> Introduce a sub directory for subtitles and OSD related code.
> Move subreader.[ch] into it.
> 
> It needs to be preceded by:
> 
> svn mkdir sub
> svn mv subreader.[ch] sub/
> 
> 
> Note: I intend to do the same for a lot of other files. If someone can hint
> me on how (1) prepare stacked patches with SVN or (2) prepare patches that
> require svn mv with Git, that would be nice.

Don't bother sending patches just for moves.
Just send a list with the filenames of the files you propose
to move, and make sure you test for compilation and grep'd
for the headers to make sure you changed the include name
also for files that might not be compiled on your system.

> -#ifndef MPLAYER_SUBREADER_H
> -#define MPLAYER_SUBREADER_H
> +#ifndef MPLAYER_SUB_SUBREADER_H
> +#define MPLAYER_SUB_SUBREADER_H

I sure don't mind, but from my point of view you don't _have_ to rename these.


More information about the MPlayer-dev-eng mailing list