[MPlayer-dev-eng] [PATCH] mencoder: correctly consider encoder delays when examining muxer time

Corey Hickey bugfood-ml at fatooh.org
Sun Oct 17 00:54:56 CEST 2010


On 2010-10-14 15:00, Alexander Roalter wrote:
>> The attached patch adds a simple function for calculating
>> delay-compensated muxer timers, and then replaces all relevant instances
>> of mux_v->timer within mencoder.c. The patched mencoder correctly
>> handles my test file that caused a segfault before.
>>
>> Does this look ok?
>>
> Apparently, it's working now. I have a few of the videos lying around
> that segfaulted mencoder, and now it's working like a charm.
> 
> Thanks for looking into it

Thanks for testing; I'm glad to hear it works.

I have an updated patch now. Changes from the previous:

* updated to current SVN (thought I was before)
* adjusted_muxer_time(): added check for muxer being null (fixes
  segfault with -nosound)

I'm threatening to apply this in three days, if nobody minds. Anyone
care to review?

Thanks,
Corey
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: encoder_delay2.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101016/d8ebcfa7/attachment.txt>


More information about the MPlayer-dev-eng mailing list