[MPlayer-dev-eng] [PATCH 2/x] Fix stereo3d stride align

[Reimar Döffinger]

On Sun, Nov 14, 2010 at 01:33:24PM +0100, Endre Kollár wrote:
> 2010/11/14 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
> > On Wed, Oct 27, 2010 at 01:36:36AM +0200, Endre Kollár wrote:
> >> -        vf->priv->width         = width / 2;
> >> -        vf->priv->in.off_right  = vf->priv->width * 3;
> >> -        vf->priv->in.stride     = vf->priv->width * 6;
> >> +        vf->priv->width           = width / 2;
> >> +        vf->priv->in.off_right_x  = vf->priv->width * 3;
> >> +        vf->priv->in.stride       = vf->priv->width * 6;
> >
> > Those reindentations make it near impossible to figure out
> > what changed, that's not ok.
> > You can also further reduce the size by keeping the
> > "off_right" name for what you here call off_right_x
> > and add a row_right instead of off_right_y for example.
> > (I don't really care so much about the specific names).
> >
> 
> Fixed variable names.
> 
> >> -        dmpi = vf_get_image(vf->next, IMGFMT_RGB24, MP_IMGTYPE_TEMP, 0,
> >> +        dmpi = vf_get_image(vf->next, IMGFMT_RGB24,
> >> +                            MP_IMGTYPE_TEMP, MP_IMGFLAG_ACCEPT_STRIDE,
> >
> > This seems unrelated.
> 
> Skipped.
> 
> >
> >> @@ -344,7 +360,6 @@ static int vf_open(vf_instance_t *vf, ch
> >>      vf->uninit          = uninit;
> >>      vf->put_image       = put_image;
> >>      vf->query_format    = query_format;
> >> -    vf->default_reqs    = VFCAP_ACCEPT_STRIDE;
> >
> > Why?
> 
> Skipped. I do not understand why it should be, if not in vf_scale.

Applied. And I now understood why the ACCEPT_STRIDE changes and
applied them in a second step, plus removed the unused "stride"
struct element.