[MPlayer-dev-eng] [PATCH] Support CineForm HD

Dan Oscarsson Dan.Oscarsson at tieto.com
Sun May 23 17:16:45 CEST 2010


sön 2010-05-23 klockan 14:31 +0200 skrev Diego Biurrun:
> On Sun, May 23, 2010 at 01:29:09AM +0200, Steinar H. Gunderson wrote:
> > On Sun, May 23, 2010 at 01:25:20AM +0200, Reimar Döffinger wrote:
> > >> +          if (data) {
> > >> +             *data = 1000;
> > >> +          }
> > >> +          if (type) {
> > >> +             *type = REG_DWORD;
> > >> +          }
> > >> +          if (count) {
> > >> +             *count = sizeof(DWORD);
> > >> +          }
> > > Pointless {}
> > 
> > Is this an established MPlayer standard? It's not consistently applied even
> > within the same file.
> 
> Let's say that it's one we try to establish :)
> All those guidelines are generally applied to new files, the old
> files are waiting for the grand refactoring..

Though the above {} need not be pointless.
It simplifies adding code later to conditional code sections, and at
least I think is is much clearer and easier to read.

   Dan




More information about the MPlayer-dev-eng mailing list