[MPlayer-dev-eng] [PATCH] Support CineForm HD

Steinar H. Gunderson sgunderson at bigfoot.com
Sat May 22 21:57:17 CEST 2010


On Fri, May 21, 2010 at 07:34:36PM +0200, Reimar Döffinger wrote:
> I suggested different ways that e.g. might work better in the long term (because
> that kind of special cases just doesn't scale and isn't maintainable).

Sure, I do agree that reducing the number of specific hacks is a good thing
in general (although MPlayer happily does things like binary patching
specific DLLs already). The loader code can never be a complete, clean
implementation of Windows, though.

> Personally, I would have considered something like below (untested) and requiring that users
> delete their old registry file acceptable and more reliable/maintainable/...
> However, only plugging the memleaks is non-optional.

OK, well, I've included a version that should plug the memory leaks from last
version. It also has a small cleanup or two so it's easier to see what the
function actually returns.

/* Steinar */
-- 
Homepage: http://www.sesse.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-cineform-v4.diff
Type: text/x-diff
Size: 2390 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100522/4532cc76/attachment.diff>


More information about the MPlayer-dev-eng mailing list