[MPlayer-dev-eng] [RFC] internal library copies

[Diego Biurrun]

On Sat, Mar 27, 2010 at 08:55:58PM +0100, Reimar Döffinger wrote:
> On Thu, Mar 25, 2010 at 07:09:56PM +0100, Diego Biurrun wrote:
> > On Wed, Mar 17, 2010 at 07:50:08PM +0100, Reimar Döffinger wrote:
> > > On Wed, Mar 17, 2010 at 01:03:21PM +0100, Diego Biurrun wrote:
> > > > * liba52
> > > > 
> > > > The internal copy was disabled some time ago, FFmpeg is both faster and
> > > > more featureful.  We support building against the external version.  Our
> > > > copy is patched, but upstream is dead and the patches have been rejected
> > > > IIRC.
> > > > verdict: drop
> > > 
> > > Hm? IIRC FFmpeg was a lot slower originally and even now is still a bit slower.
> > > And upstream is a lot slower, so it seems to me that removing it would remove
> > > the fastest decoder available.
> > > Not that I mind much.
> > 
> > Hmm, you disabled liba52.  Can somebody provide numbers?  I think FFmpeg
> > was faster, even for my K6-III...
> 
> These are the numbers I got back then:
> As of 2010-01-04 mplayer/ffmpeg-mt:
> $ time mplayer -nocache -novideo -vc null -vo null \
> -ao pcm:fast:nowaveheader:file=/dev/null -benchmark /path/to/file.mkv
> 
> 2ch/224kbps/-aid 0
> liba52: real    0m10.027s user   0m9.433s sys   0m0.424s
> ffac3:  real    0m11.079s user  0m10.289s sys   0m0.532s
> 6ch/448kbps->downmix 2ch/-aid 1 -channels 2
> liba52: real    0m17.246s user  0m16.269s sys   0m0.564s
> ffac3:  real    0m19.884s user  0m18.873s sys   0m0.536s
> 6ch/448kbps->6ch/-aid 1 -channels 6
> liba52: real    0m26.187s user  0m24.410s sys   0m0.816s
> ffac3:  real    0m27.093s user  0m25.790s sys   0m0.808s

time mplayer -demuxer lavf -ac ffac3 -nocache -novideo -quiet -benchmark -ao pcm:fast:nowaveheader:file=/dev/null Canyon-5.1-48khz-448kbit.ac3 

6ch/448kbps->downmix 2ch/-channels 2
liba52: real    0m2.772s user    0m2.504s sys     0m0.072s
ffac3:  real    0m1.999s user    0m1.752s sys     0m0.076s

6ch/448kbps->6ch/-channels 6
liba52: real    0m5.119s user    0m4.832s sys     0m0.104s
ffac3:  real    0m2.385s user    0m2.100s sys     0m0.092s


time mplayer -ac ffac3 -nocache -novideo -quiet -benchmark -ao pcm:fast:nowaveheader:file=/dev/null MainConceptEncoded-sample.mpg 

liba52: real    0m1.019s user    0m0.620s sys     0m0.192s
ffac3:  real    0m0.881s user    0m0.488s sys     0m0.192s


These numbers are from my K6-III with 3dnowext and mmx, but no mmx2
or sse.  What machine did you test on?

I think we should remove liba52.

Diego