[MPlayer-dev-eng] [PATCH] improve dvd subtitle. cmd 7 (CHG_COLCON)

[Michael Niedermayer]

On Sat, Mar 13, 2010 at 06:03:52PM +0900, A Tanaka wrote:
> On Wed, 10 Mar 2010 23:45:47 +0100
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > > +    this->imagebuf_size = 2 * this->image_size;
> > > +    this->imagebuf = malloc(this->imagebuf_size);
> > 
> > This could be aligned.
> 
> > > +  if (this->image_size == 0 || this->imagebuf == NULL) {
> > > +    this->height = 0;
> > > +    this->image_size = 0;
> > > +    this->image = NULL;
> > > +    this->aimage = NULL;
> > >      return;
> > > +  }
> > > +
> > > +  this->image = this->imagebuf;
> > > +  this->aimage = this->imagebuf + this->image_size;
> > 
> > These could be aligned as well, more below.
> 
> What does 'aligned' means? like this?
> a   = 1;
> bb  = 2;
> ccc = 3;

yes


> 
> If so, no such alignments are used in current spudec.c.

then current spudec is ugly written :)


> Do I need change my code?

i belive this is what diego meant

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100318/41198425/attachment.pgp>