[MPlayer-dev-eng] [PATHC] define O_BINARY in stream.h

[KO Myung-Hun]

Diego Biurrun wrote:
> On Thu, Mar 04, 2010 at 01:09:36AM +0900, KO Myung-Hun wrote:
>>
>> Define O_BINARY in stream/stream.h unless it is defined yet, and use it
>> in other places.
>>
>> This removes platform specific checks and prevents repeated definitions
>> of O_BINARY.
>>
>> --- stream/stream_file.c	(revision 30819)
>> +++ stream/stream_file.c	(working copy)
>> @@ -136,9 +136,7 @@
>>
>> -#if defined(__CYGWIN__)|| defined(__MINGW32__) || defined(__OS2__)
>>     m |= O_BINARY;
>> -#endif
>
> This looks wrong since previously it was only done for DOS platforms..
>

If so, do you know the platforms with O_BINARY other than DOS ones ?

I know, BeOS does. But as Reimar said in other thread, it has no effect.

In addition, you accepted the same patch for stream_cddb.c. Nevertheless 
why do you say that it is wrong this time ?


-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0
Under OS/2 Warp 4 for Korean with FixPak #15
On Intel Core2Duo T5500 1.66 GHz with 1 GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr