[MPlayer-dev-eng] [PATCH] Tags support for SubRip and MicroDVD subtitles [v3]

[ubitux]

On Tue, Jun 22, 2010 at 04:40:37AM -0300, Kazuo Teramoto wrote:
> 2010/6/19 ubitux <ubitux at gmail.com>:
> >+                        /* Let's put some white in case we didn't find
> >+                         * any matching colors */
> >+                        tag->color = 0x00ffffff;
> >+
> 
> Ubitux, this dont look correct for me, white is not a default color.
> If you remember the patch I send for the web color support when it
> don't found a matching color its broke the loop, this behavior set the
> color for the "default one", i.e. the one current set.
> 

Well sorry about that. I've added a piece of code that reset the color to
the default ASS color (and without any goto :p), and then continue to
parse the other attributes. You'll see it in the next patch I'll send with
Diego wanted changes.

> And I think that we can have a more fully attribute parsing (i.e. as
> described by http://www.w3.org/TR/html-markup/syntax.html#syntax-attributes
> ), But I think this can be done latter.
> 

I really don't agree with this HTML mess, and I don't think any SubRip
parser is doing that… If you start to implement that, do you consider we
should support <font color    =       blue'> ?

> I like to say that I'm using a version of ubitux patch in daily basis
> for SubRip subs with great successes, works great for all the
> subtitles I used, so +1 from me.
> 
> Regards,
> Kazuo
> 
> -- 
> «Dans la vie, rien n'est à craindre, tout est à comprendre»
> Marie Sklodowska Curie.
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

-- 
ubitux