[MPlayer-dev-eng] [PATCH] Support CineForm DirectShow codec

[Reimar Döffinger]

On Sun, Jan 10, 2010 at 04:17:45PM +0100, Steinar H. Gunderson wrote:
> On Sun, Jan 10, 2010 at 04:07:05PM +0100, Reimar Döffinger wrote:
> > I strongly suggest you split this and submit the "obvious" bug fixes and
> > implementations of simple new stub functions separately.
> > They have a good chance of being accepted reasonably fast and makes the rest of
> > the patch much easier to review without all the "clutter"
> 
> OK. How about this patch? Nothing CineForm-specific, no new stub functions.
> 
> /* Steinar */
> 
> 
> diff -Nur orig/mplayer-export-2010-01-02/loader/dshow/interfaces.h mplayer-export-2010-01-02/loader/dshow/interfaces.h
> --- orig/mplayer-export-2010-01-02/loader/dshow/interfaces.h	2008-02-23 15:50:55.000000000 +0100
> +++ mplayer-export-2010-01-02/loader/dshow/interfaces.h	2010-01-06 01:07:14.000000000 +0100
> diff -Nur orig/mplayer-export-2010-01-02/loader/registry.c mplayer-export-2010-01-02/loader/registry.c
> --- orig/mplayer-export-2010-01-02/loader/registry.c	2009-05-04 19:35:26.000000000 +0200
> +++ mplayer-export-2010-01-02/loader/registry.c	2010-01-06 21:09:22.000000000 +0100
> @@ -385,7 +385,7 @@
>      if(handle==head)
>  	head=head->prev;
>      free(handle);
> -    return 1;
> +    return 0;
>  }
>  
>  long __stdcall RegQueryValueExA(long key, const char* value, int* reserved, int* type, int* data, int* count)
> diff -Nur orig/mplayer-export-2010-01-02/loader/win32.c mplayer-export-2010-01-02/loader/win32.c
> --- orig/mplayer-export-2010-01-02/loader/win32.c	2009-10-10 11:27:22.000000000 +0200
> +++ mplayer-export-2010-01-02/loader/win32.c	2010-01-10 14:00:54.000000000 +0100
> @@ -208,8 +208,8 @@
>  	vprintf(fmt, va);
>  //	mp_dbg(MSGT_WIN32, MSGL_DBG3, fmt, va);
>  	va_end(va);
> +        fflush(stdout);
>      }
> -  fflush(stdout);
>  }

Applied.
The pthread stuff needs some serious explaining, and I really think
it should be done without the pthread_mutexattr_settype stuff if at all
possible (well, actually it is certainly possible).