[MPlayer-dev-eng] [PATCH] Support CineForm DirectShow codec

[Reimar Döffinger]

On Sun, Jan 10, 2010 at 03:45:58PM +0100, Steinar H. Gunderson wrote:
> On Fri, Jan 08, 2010 at 12:23:20AM +0100, Steinar H. Gunderson wrote:
> > Here is a patch to support CineForm, a relatively popular HD intermediate
> > codec, in MPlayer. It's a bit raw (segfaults on exit, for one), but at least
> > it's a usable starting point.
> 
> I found out there were corruption problems with the previous patch, so I
> debugged a bit further. Here's an updated version, with the following
> changes:

I strongly suggest you split this and submit the "obvious" bug fixes and
implementations of simple new stub functions separately.
They have a good chance of being accepted reasonably fast and makes the rest of
the patch much easier to review without all the "clutter"
Testing of as many other binary codecs as possible with this patch would
be highly welcome as well, a patch that adds support for such a "fringe"
codec at the expense of breaking many of the more important ones wouldn't
be a good tradeoff...