[MPlayer-dev-eng] New patch for play DVD's with dvdnav://

[Carl Eugen Hoyos]

 <jaime.gemelo <at> free.fr> writes:

> Here is a new version of the "04_dvdnav.patch"

Thank you for working on this!

Just a few cosmetic comments, somebody else will hopefully do a complete review:

[...]

> @@ -240,10 +250,16 @@
>        case DVDNAV_VTS_CHANGE: {
>          priv->state &= ~NAV_FLAG_WAIT_SKIP;
>          priv->state |= NAV_FLAG_STREAM_CHANGE;
> +		priv->state |= NAV_FLAG_AUDIO_CHANGE;

Please do not mix the (existing) spaces with (your) tabs.

         break;
       }
       case DVDNAV_SPU_STREAM_CHANGE: {
         priv->state |= NAV_FLAG_STREAM_CHANGE;
+        priv->state |= NAV_FLAG_STREAM_CHANGE;

Duplicated line?

[...]

@@ -946,15 +1032,9 @@
  * \return 1 if audio has changed
  */
 int mp_dvdnav_audio_has_changed (stream_t *stream, int clear) {
-  dvdnav_priv_t *priv = stream->priv;
-
-  if (!(priv->state & NAV_FLAG_AUDIO_CHANGE))
-    return 0;
-
-  if (clear)
-    priv->state &= ~NAV_FLAG_AUDIO_CHANGE;
-
-  return 1;
+  dvdnav_priv_t * priv = stream->priv;
+  if(!(priv->state & NAV_FLAG_AUDIO_CHANGE)) return 0;
+  if(clear) return 1;

Please remove all cosmetic changes from this hunk (1 line removed, 1 added, if I
see that correct)

Carl Eugen