[MPlayer-dev-eng] [PATCH] prefix EXTERN_ASM to global variables in wrapper.S

[Diego Biurrun]

On Fri, Feb 05, 2010 at 12:39:57AM +0900, KO Myung-Hun wrote:
>
> Diego Biurrun wrote:
>> On Thu, Feb 04, 2010 at 03:03:56PM +0900, KO Myung-Hun wrote:
>>>
>>> --- loader/wrapper.S	(revision 30495)
>>> +++ loader/wrapper.S	(working copy)
>>> @@ -1,27 +1,33 @@
>>> -.section .data
>>> -.globl caller_return
>>> -caller_return:
>>> +#include "config.h"
>>> +
>>> +#define GLUE(a, b) a ## b
>>> +#define JOIN(a, b) GLUE(a, b)
>>> +#define X(s)       JOIN(EXTERN_ASM, s)
>>
>> I think X is a very poor macro name.
>
> How about MANGLE ? ^^

Fine with me.

> --- loader/wrapper.S	(revision 30502)
> +++ loader/wrapper.S	(working copy)
> @@ -1,27 +1,33 @@
> -.section .data
> -.globl caller_return
> -caller_return:
> +#include "config.h"
> +
> +#define GLUE(a, b) a ## b
> +#define JOIN(a, b) GLUE(a, b)
> +#define MANGLE(s)  JOIN(EXTERN_ASM, s)

Unless I'm completely daft, the JOIN macro is just a transparent
wrapper around the GLUE macro.  Plus, the GLUE macro could be
directly incorporated into the MANGLE macro.

Diego