[MPlayer-dev-eng] [Patch] fix ivtv cvidix in configure-script

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Feb 2 20:08:46 CET 2010


On Tue, Feb 02, 2010 at 12:08:05AM +0100, Martin Dauskardt wrote:
> > > diff -ur mplayer-old/vidix/ivtv_vid.c mplayer-new/vidix/ivtv_vid.c
> > > --- mplayer-old/vidix/ivtv_vid.c      2010-01-24 19:06:43.277260784 +0100
> > > +++ mplayer-new/vidix/ivtv_vid.c      2010-01-24 19:18:11.977259993 +0100
> > 
> > Is that part actually necessary? Why?
> see explanation in
> <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2010-January/063394.html>
> > 2.6.22 is not that old that the code to support version before it should be
> > dropped unless it is really necessary (on thinking again it might actually
> > be that old, still...).
> The old code (which I removed) requires the old ivtv-driver (version 0.10) 
> which is not part of the kernel.
>
> Using LINUX_VERSION_CODE inside the ivtv vidix driver is not a good idea:
> One could have a Debian Etch (LINUX_VERSION_CODE says 2.6.18) but uses a 
> current v4l2-dvb hg with new ivtv API.

Ok, in that case I fully agree with it, thanks for explaining.
Maybe Diego can be convinced to beat the configure part in shape? :-)



More information about the MPlayer-dev-eng mailing list