[MPlayer-dev-eng] [PATCH] unified timing patch for H264

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Aug 29 19:33:26 CEST 2010


On Sun, Aug 29, 2010 at 07:23:09PM +0200, Reimar Döffinger wrote:
> On Sun, Aug 29, 2010 at 05:46:29PM +0200, Pásztor Szilárd wrote:
> > Reimar Döffinger:
> > > > -                   int drop_frame, double pts)
> > > > +                   int drop_frame, double pts, int *full_frame)
> > > 
> > > This extra argument is no longer used anywhere in this patch,
> > > so it shouldn't be added here.
> > 
> > Huh? This extra argument is almost the whole point of the patch...
> 
> It is not used anywhere in mplayer-2010-08-29-pts-reorder.patch,
> so it shouldn't be added in tthe address of those is then
> pass to that function, but you never use those variables.

Argh, where went all my text...
I was trying to say you do add several full_frame variables
and pass their address, but never check their value.
So this new argument isn't really used anywhere (when
only looking at that patch).


More information about the MPlayer-dev-eng mailing list