[MPlayer-dev-eng] [PATCH] Remove nonsensical error output

Ryan Mullen rm at deconfused.org
Tue Aug 24 00:16:29 CEST 2010


Hello,

When passing a URL to the -playlist option, mplayer previously printed
nonsensical things like this:

(For a 404 URL)
Error while opening playlist file http://soma.fm/1921929.pls:
Operation now in progress

(For a non-existent network name)
Error while opening playlist file http://notasite.tld/playlist.pls: Success

Rather than printing the string attached to the errno (which clearly
is of no value) just state that the playlist was unable to be opened.

Thanks for your consideration,
Ryan

Index: playtreeparser.c
===================================================================
--- playtreeparser.c	(revision 32011)
+++ playtreeparser.c	(working copy)
@@ -772,7 +772,7 @@
   stream = open_stream(file,0,&f);

   if(!stream) {
-    mp_msg(MSGT_PLAYTREE,MSGL_ERR,"Error while opening playlist file
%s: %s\n",file,strerror(errno));
+    mp_msg(MSGT_PLAYTREE,MSGL_ERR,"Error while opening playlist file
%s\n",file);
     return NULL;
   }


More information about the MPlayer-dev-eng mailing list