[MPlayer-dev-eng] [PATCH] Correctly detect sockaddr_storage on OpenBSD

[Attila Kinali]

On Tue, 03 Aug 2010 16:30:54 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Tue, Aug 03, 2010 at 03:08:52PM +0100, Edd Barrett wrote:
> > <sys/socket.h> requires <sys/types.h> on OpenBSD.
> 
> Then why does sys/socket.h not #include sys/types.h on OpenBSD?
> 
> Again, I think you are patching the wrong side.  Fix the header on
> OpenBSD once and you will make hundreds of packages work immediately
> instead of manually submitting patches to a trillion projects...

We have bigger hacks for other systems. I think that including
an additional headerfile is quite harmless. Our ranting here,
that *BSD has too many anachronisms wont help, as you cannot
change the way an old elephant walks on. You can only scare him,
which will get you stamped on.

Beside, socket(2) explicitly notes:
---schnapp---
       POSIX.1-2001  does not require the inclusion of <sys/types.h>, and this
       header file is not required on Linux.  However, some  historical  (BSD)
       implementations  required  this  header file, and portable applications
       are probably wise to include it.
---schnapp---

As i don't see any problems caused by including sys/types.h, we should
IMHO include it unconditionally.

			Attila Kinali


-- 
If you want to walk fast, walk alone.
If you want to walk far, walk together.
		-- African proverb