[MPlayer-dev-eng] [RFC][PATCH v2] Add support for 12-bit color mode. (to mplayer)

Uoti Urpala uoti.urpala at pp1.inet.fi
Fri Apr 2 20:34:13 CEST 2010


On Fri, 2010-04-02 at 19:38 +0200, Janusz Krzysztofik wrote:
> Friday 19 March 2010 01:52:42 Janusz Krzysztofik wrote:
> > The patch extends mplayer with RGB12 aka RGB444 pixel format handling.
> > It works for me with fbdev and fbdev2, selecting required color conversion
> > filters automatically. It also works with directfb when provided with "-vf
> > format=bgr12" option. I wasn't able to get correct results using sdl,
> > neither with qtopia (incorrect collors) nor fbcon (not working at all)
> > drivers. I haven't tested the x11 output driver modifications.

> Since there were no comments on this patch since I submitted 2 weeks ago, 
> nor has it been acknowledged by anyone,

I think most of the people who could comment on color conversion
handling don't care about framebuffer VOs. I never use them myself, and
they generally haven't got much attention from any developer. So
probably nobody has been motivated to test or review.

>   am I supposed to do something more 
> for it to be reviewed and possibly applied?

I don't think so - I haven't looked at your patch in any detail, but the
way you presented it looks at least superficially sane and good enough
for some level of review.




More information about the MPlayer-dev-eng mailing list