[MPlayer-dev-eng] [PATCH] demux_mkv.c: fix crash with gcc 4.4 and optimizations

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Sep 30 10:24:51 CEST 2009


On Wed, Sep 30, 2009 at 01:13:35AM -0700, Corey Hickey wrote:
> Reimar Döffinger wrote:
> > In case -Wstrict-aliasing=2 is reliable, this much simpler patch will
> > fix it too.
> 
> Looks good; I tested it and it seems fine. No warnings, no segfault.

Well, hopefully it is fixed in SVN then. And hopefully I'll some day
learn that void ** has aliasing issues and only void * hasn't.
I still don't like that solution much, _maybe_ it would be nicer to make
grow_array instead return a value, but I don't like that much either.



More information about the MPlayer-dev-eng mailing list