[MPlayer-dev-eng] [PATCH] Add DVB teletext support

Reimar Döffinger Reimar.Doeffinger at gmx.de
Thu Sep 17 21:37:20 CEST 2009


The moment you add the demuxer->teletext all the DEMUXER_TYPE_TV checks
should go since they are now pointless.
Another question is why the teletext goes into the demuxer struct, it
does not really have much to do with the demuxer, depending on how you
see it, it either is a global state or it is associated with a specific
subtitle stream.
I also particularly dislike the tvh->demuxer, why pass around the whole
demuxer when the teletext part in it would be enough? (I also have not
been able to find where tvh->demuxer is set, whether that is because I
am blind or because it was forgotten and thus broke "normal" teletext
support I don't know).



More information about the MPlayer-dev-eng mailing list