[MPlayer-dev-eng] [PATCH] Add support for ARIB STD-B24 captions v3

Michael Wu altape at eden.rutgers.edu
Thu Oct 29 23:29:15 CET 2009


> On Mon, 2009-10-26 at 19:16 -0400, altape at eden.rutgers.edu wrote:
>> - Add setup_sh_sub to finish setup of sh_sub_t after new_sh_sub_sid
>
> While this solves the demuxer-specificity problem I don't like it any
> better overall. Audio and video have no such functions either. Maybe a
> function called for tracks discovered late after the opening phase
> _only_ would be OK; those could require other kinds of special handling
> too.
Doing it this way has the advantage of eliminating the loop through the
s_streams table. If the loop is kept, setup_sh_sub would only need to be
called in the case of arib. Would you prefer that over eliminating the
loop?

-Michael Wu



More information about the MPlayer-dev-eng mailing list