[MPlayer-dev-eng] [PATCH] fix length in asf files

compn tempn at twmi.rr.com
Tue Nov 10 23:48:55 CET 2009


On Tue, 10 Nov 2009 18:43:24 +0100, Reimar Döffinger wrote:
>On Tue, Nov 10, 2009 at 10:07:48AM -0500, compn wrote:
>> asfheader-force_best_stream.diff
>
>Will probably break mms in many cases, since the "best" stream
>this selects might not actually be available.

i thought mms code had its own auto-selection. at least this wmv
feature request is here:
http://bugzilla.mplayerhq.hu/show_bug.cgi?id=427

>> mencoder_03_joint_av_eof.diff
>
>Ugh, I don't think we should risk calling muxer_write_chunk with len <=
>0.
>Apart from that I am not sure which behaviour is more desirable: stop
>encoding when both streams end or as soon as one ends...

might be good as option, at least then user could choose.

>> mencoder_04_av_sync_hack.diff
>
>Likely this just covers up a rather big bug somewhere else.
>
>> mencoder_05_mov_lavf_pts_var_fps.diff
>> mencoder_06_asf_pts_passing.diff
>> mencoder_07_demux_update_pts.diff
>> mencoder_09_rebase_pts_when_seeking.diff
>> mencoder_10_correct_pts.diff
>
>Looks like a partial correct-pts implementation for mencoder.
>Not so great for us I think, even without the needless code duplication.

some of these patches may fix some of these bugs:
http://bugzilla.mplayerhq.hu/show_bug.cgi?id=879
http://bugzilla.mplayerhq.hu/show_bug.cgi?id=1416
http://bugzilla.mplayerhq.hu/show_bug.cgi?id=629


>> vd_ffmpeg-restrict_dimension_correction.diff
>
>No idea at all. Part of the patch is for lavf though...

related to this issue?
http://roundup.ffmpeg.org/roundup/ffmpeg/issue32


>> vd_qtvideo-validate_ImageDesc_size.diff
>
>yes, unfortunately lavf does not give us everything necessary to use QT
>binary decoders :-(
i wonder if it fixes:
http://roundup.ffmpeg.org/roundup/ffmpeg/issue1322
http://roundup.ffmpeg.org/roundup/ffmpeg/issue1320

-compn



More information about the MPlayer-dev-eng mailing list