[MPlayer-dev-eng] [PATCH][TRIVIAL] Few cosmetics to x11_common

Reynaldo H. Verdejo Pinochet reynaldo at opendot.cl
Tue Nov 3 22:10:29 CET 2009


Hello Again

Reimar Döffinger wrote:
> 
> That one is of course fine, as well as quite a few other
> changes.

Just thinking out loud here. Do you like these? I usually
surround if/while statements with blanks.

Index: x11_common.c
===================================================================
--- x11_common.c        (revision 29818)
+++ x11_common.c        (working copy)
@@ -189,16 +189,18 @@
         return;                 // do not hide if playing on the root
window

     colormap = DefaultColormap(disp, DefaultScreen(disp));
+
     if ( !XAllocNamedColor(disp, colormap, "black", &black, &dummy) )
-    {
       return; // color alloc failed, give up
-    }
+
     bm_no = XCreateBitmapFromData(disp, win, bm_no_data, 8, 8);
     no_ptr = XCreatePixmapCursor(disp, bm_no, bm_no, &black, &black, 0, 0);
     XDefineCursor(disp, win, no_ptr);
     XFreeCursor(disp, no_ptr);
+
     if (bm_no != None)
         XFreePixmap(disp, bm_no);
+
     XFreeColors(disp,colormap,&black.pixel,1,0);
 }

--
Reynaldo



More information about the MPlayer-dev-eng mailing list