[MPlayer-dev-eng] [PATCH] add -ldvdcss when dvdcss is external

[Uoti Urpala]

On Sat, 2009-05-09 at 16:06 +0100, vmrsss wrote:
> On 9 May 2009, at 14:07, Uoti Urpala wrote:
> > Unless there is some special
> > reason to do otherwise, I'd say this is a bug in libdvdread (at  
> > least in
> > the version you compiled)- when it is compiled for direct use of the
> > symbols (non-dlopen version) it should link the shared library against
> > libdvdcss. MPlayer should not have to give any -l flags for indirect
> > dependencies of shared libraries.
> 
> Yes, this makes sense, if that's the case then dvdread should list - 
> ldvdcss in the output of "dvdread-config --libs". I look into it.

It should NOT give any such linker arguments for the using program in
the shared library case (unless libdvdcss symbols are exposed to the
main program through libdvdread headers and so the main program needs to
link against libdvdcss too, but I doubt that is the case when the same
headers also support dlopen mode). Instead the libdvdread library should
itself link against libdvdcss.