[MPlayer-dev-eng] [PATCH] Improved MMS over TCP support

Francesco Cosoleto cosoleto at gmail.com
Fri Mar 20 11:01:44 CET 2009


Reimar Döffinger wrote:
> Sorry, but there is no way I can consider that patch "short", and that
> it rewrites code makes it near impossible to check the code for
> regressions nor do we have a regression test for mms (well, for MPlayer
> we actually don't have any regression tests :-( ).
> So unless someone else reviews it or applies it hoping for good luck it
> won't break much it will have to wait till I have that much time.
> As I understand the description it fixes several separate issues,
> separating the patches will make reviewing and fixing regressions
> easier, too.

So, with the passing of time, maybe I have underestimated its length,
sorry. There are similarity with the MMS over HTTP code that could help,
I hope. I have split the patch in three parts and simplified a bit, it
should be more readable now.

I have to report that the code is tested with at least 40 MMS URLs (yes,
this requires time), and the test has pointed out no regression, except
that a DRM stream was't recognized and MPlayer tries to play it.

Thanks,
-- 
Francesco Cosoleto | http://cosoleto.free.fr

"Noi esercitiamo il potere con l'amore, non con le armi" (J. P. 
Goebbels, ministro della cultura del governo nazionalsocialista tedesco, 
1936)




More information about the MPlayer-dev-eng mailing list