[MPlayer-dev-eng] [PATCH] vo_kva

[KO Myung-Hun]

Hi/2.

Diego Biurrun wrote:
>> --- libvo/vo_kva.c	(revision 0)
>> +++ libvo/vo_kva.c	(revision 0)
>> @@ -0,0 +1,1193 @@
>> +static void imgDisplay(void)
>> +{
>> +    PVOID       pBuffer;
>> +    ULONG       ulBPL;
>>     
>
> Any particular reason to use so many spaces?  Not that it matters..
>
>   

No. But maybe it's due to my habit of align variables. I think there 
were a variable with long name type and deleted it, then I didn't 
realign them.

Fixed, anyway.

>> +#define MRETURN(ret)  return (MRESULT)(ret)
>>     
>
> This just looks like obfuscation to me.
>
>   

I agree not, but changed.

>> +    WinRegisterClass(
>> +        m_int.hab,
>> +        WC_MPLAYER,
>> +        WndProc,
>> +        CS_SIZEREDRAW | CS_MOVENOTIFY,
>> +        sizeof(PVOID)
>> +   );
>>     
>
> That's a weird way to format the function.  Please be consistent with
> the rest.
>
>   

Fixed.

>> +static void check_events(void)
>> +{
>> +}
>> +
>> +
>>     
>
> nit: stray empty lines
>
>   

Deleted.

>> --- DOCS/man/en/mplayer.1	(revision 28767)
>> +++ DOCS/man/en/mplayer.1	(working copy)
>> @@ -3573,6 +3585,23 @@
>> +.IPs (no)t23
>> +Enable/disable workaround for T23 laptop (default: \-not23).
>> +Try to enable this option, if your video card supports up-scaling only.
>>     
>
> Upscaling, leave out the comma.
>
>   

Fixed.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: kva.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090301/6eb8921e/attachment.asc>