[MPlayer-dev-eng] [PATCH] fix inconsistencies in libvo/geometry.c

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Jun 26 13:17:31 CEST 2009


On Fri, Jun 26, 2009 at 06:01:38AM -0400, Benson Mitchell wrote:
> In geometry.c, -1 and INT_MIN were used alternately for unspecified values
> of the same variables; it appears some partial conversion was in progress,
> but never finished.

No, anything < 0 is used for width/height because width < 0 is not
valid. There is a good chance that with your change you end up with
MPlayer trying to create a window with size < 0 and the crashing or
doing something else that makes no sense.
INT_MIN is used for the offsets because negative values make perfect
sense for those, though INT_MIN has a reasonable chance that nobody will
actually want to use it.



More information about the MPlayer-dev-eng mailing list