[MPlayer-dev-eng] [PATCH] LIRC input: minor fix, cleanups, and proper select(2)

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Jan 28 17:02:37 CET 2009


On Thu, Jan 29, 2009 at 04:02:21AM +1300, Dennis Vshivkov wrote:
> Comments?

I think you have a weird way of combining fixes into a patch that makes
them look far more complicated than they are.
Also cleaning up code that will be removed anyway does not make that
much sense.
I was thinking of something simple like attached patch as a first step,
but I can't test it.

Greetings,
Reimar Döffinger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lirc_simplify.diff
Type: text/x-diff
Size: 1773 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090128/0c2e6231/attachment.diff>


More information about the MPlayer-dev-eng mailing list