[MPlayer-dev-eng] [PATCH] Support for DVB subtitles

[Diego Biurrun]

On Sat, Feb 28, 2009 at 12:17:14PM +0100, Nicolas George wrote:
> 
> --- /dev/null
> +++ b/dvbsub.c
> @@ -0,0 +1,219 @@
> +#include "mplayer.h"
> +#include "mp_msg.h"
> +#include "libavcodec/avcodec.h"
> +#include "dvbsub.h"

Please add our standard license header.

> +typedef struct dvbsub_frame dvbsub_frame_t;

typedefs are ugly and the _t namespace is reserved by POSIX.

> +static void dvbsub_add_frame(dvbsub_track_t *track, double start, double end,
> +    AVSubtitleRect **rect, int n_rect)

Align like this:

static void dvbsub_add_frame(dvbsub_track_t *track, double start, double end,
                             AVSubtitleRect **rect, int n_rect)

same below

> +    frame->start = start;
> +    frame->end = end;
> +    frame->rect = rect;
> +    frame->n_rect = n_rect;

Things like these could be aligned.

> --- /dev/null
> +++ b/dvbsub.h
> @@ -0,0 +1,18 @@
> +#ifndef MPLAYER_DVBSUB_H
> +#define MPLAYER_DVBSUB_H

license header

Diego